Does not compile as this adds a new alias to the spec.

Does not compile as this adds a new alias to the spec.

Please move the new checks into a compile-time disabled test case!

Please move the new checks into a compile-time disabled test case!

I went with a simple approach as that'd mean having conditionally compiled template functions to avoid using an undefined type and would overcomplicate tests too much to get same degree of coverage.

Note this same approach is taken in other places like

I went with a simple approach as that'd mean having conditionally compiled template functions to avoid using an undefined type and would overcomplicate tests too much to get same degree of coverage.

It might be simpler but it also hides the fact that an implementation does in fact not fully pass the test case. If you use the DISABLED_FOR_TEST_CASE method, the test will fail at runtime. AdaptiveCpp (formerly hipSYCL) does not strive to achieve conformance with 2020, so the code is still littered with SYCL_CTS_COMPILING_WITH_HIPSYCL. Intel on the other hand made an effort to get rid of all of these before doing their first conformance submission. Adding these back in now means that we have to remember to remove them before the next conformance submission is made.

Edit: I can see that it might be annoying to get it working with the whole typing boilerplate that is going on for those tests. Alternatively you could add an #else branch with an explicit call to FAIL!

I went with a simple approach as that'd mean having conditionally compiled template functions to avoid using an undefined type and would overcomplicate tests too much to get same degree of coverage.

It might be simpler but it also hides the fact that an implementation does in fact not fully pass the test case. If you use the DISABLED_FOR_TEST_CASE method, the test will fail at runtime. AdaptiveCpp (formerly hipSYCL) does not strive to achieve conformance with 2020, so the code is still littered with SYCL_CTS_COMPILING_WITH_HIPSYCL. Intel on the other hand made an effort to get rid of all of these before doing their first conformance submission. Adding these back in now means that we have to remember to remove them before the next conformance submission is made.

Edit: I can see that it might be annoying to get it working with the whole typing boilerplate that is going on for those tests. Alternatively you could add an #else branch with an explicit call to FAIL!

I defined two additional tests. I still need conditional compilation as they would fail to compile otherwise.